Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #216

Merged
merged 16 commits into from Sep 10, 2019
Merged

Testing #216

merged 16 commits into from Sep 10, 2019

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Jul 19, 2019

Problem

  • Application is not up-to-date

Solution

  • Upgrade to latest version 15.0.10

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Maniack C
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@kay0u
Copy link
Member Author

kay0u commented Jul 19, 2019

@JimboJoe There is the version 15.0.10, but I still don't undersand how you create the .patch 😄

@kay0u kay0u requested a review from a team July 24, 2019 08:40
JimboJoe
JimboJoe previously approved these changes Aug 6, 2019
Copy link
Contributor

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@JimboJoe
Copy link
Contributor

JimboJoe commented Aug 6, 2019

Can be merged in 3 days.

[fix] Copy only app missing in new apps dir
@zamentur zamentur dismissed stale reviews from JimboJoe and maniackcrudelis via e0b4a5a August 7, 2019 15:45
@JimboJoe
Copy link
Contributor

JimboJoe commented Aug 9, 2019

Following the recent new merge, needs another round of review @YunoHost-Apps/apps-group

@JimboJoe JimboJoe requested a review from a team August 17, 2019 07:04
@kay0u
Copy link
Member Author

kay0u commented Aug 19, 2019

Need one LGTM :-)

@mediaformat
Copy link

reviewers please!

@JimboJoe JimboJoe merged commit 0e69e01 into master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants