Allow public apps with no sso tile

[kay0u]

The problem

https://forum.yunohost.org/t/yunohost-3-7-spooky-testing-call-for-feedback/9385/49?u=kayou
https://forum.yunohost.org/t/yunohost-3-7-spooky-testing-call-for-feedback/9385/50?u=kayou

Solution

...

PR Status

Not fully tested, any though about it?

How to test

...

Validation

• Principle agreement 0/2 :
• Quick review 0/1 : Josué
• Simple test 0/1 :
• Deep review 0/1 :

[Josue-T]

Look like good for me, but haven't tested yet.

Thanks for the quick fix.

[alexAubin]

I suppose it does sort of cover the use case discussed on the forum. On the other hand, as for everything with the permission system, it's touchy because there are plenty of different scenario and use case to consider and everything has to be tested and thought about with precautions ...

I thought about it a bit and it seems okay, but I really can't say for sure that there aren't any piece of code (maybe in app_ssowatconf or related) doing some assumptions about this ... Also gotta be careful about what happens in app_install (and in particular the _migrate_legacy_permission) and in the migration procedure.

We probably want to update the group permission doc here to advise using

ynh_permission_update --permission "main" --add visitors all_users

instead of just adding visitors, otherwise we're going to have many users finding it weird that the app they just installed does not appear in their sso ...

[kay0u]

I've tried every case I can think of, it works for me...

We were supposed to release version 3.7 this week, so I guess it's delayed, again?

[Josue-T]

I thought about it a bit and it seems okay, but I really can't say for sure that there aren't any piece of code (maybe in app_ssowatconf or related) doing some assumptions about this ... Also gotta be careful about what happens in app_install (and in particular the _migrate_legacy_permission) and in the migration procedure.

I'll try this week to update all of my apps with group-permission support. So it will be a good occasion to see if we still have some bug or not.