Convert bool-like string arguments to actual bool #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
I need to be able to send a boolean argument '
force':True
(equivalent to--force
) from the webadmin in the context of a POST request.However, turns out that transmitting booleans in POST data is not 100% trivial since only strings are transmitted anyway. So far we did not need such a thing...
Proposed solution
I could do some dirty hack in my command API but that wouldnt be pretty for CLI users ... So instead I propose this fix were, if an arg looks like a boolean (i.e.
"true"
or"false"
) it is converted toTrue/False