Fix coding style #178
Merged
Fix coding style #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coding style checker: pep8 --ignore E501,E128,E731 <...>
|
Made a quick review, looks legit to me as well so merging as a micro decision. Thanks again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Travis-CI build fails for coding style reasons (first occurence quickly found is build #278). Some modules import unnecessary symbols.
Proposed solution
Fix coding style according to PEP8. Remove unused imports except for those explicitly marked as voluntary.
Status
Changes to make the CI build work are trivial and in principle harmless. Removal of unused imports may break client code (that shouldn't be) relying on them. Didn't check thoroughly for module import side effects within the
moulinettecode itself but doesn't seem to be the case. Ready for review.