New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding style #178

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Projects
None yet
2 participants
@airwoodix
Contributor

airwoodix commented Nov 22, 2018

Problem

The Travis-CI build fails for coding style reasons (first occurence quickly found is build #278). Some modules import unnecessary symbols.

Proposed solution

Fix coding style according to PEP8. Remove unused imports except for those explicitly marked as voluntary.

Status

Changes to make the CI build work are trivial and in principle harmless. Removal of unused imports may break client code (that shouldn't be) relying on them. Didn't check thoroughly for module import side effects within the moulinette code itself but doesn't seem to be the case. Ready for review.

airwoodix added some commits Nov 22, 2018

Adjust coding style to make CI build pass.
Coding style checker: pep8 --ignore E501,E128,E731 <...>
@alexAubin

This comment has been minimized.

Member

alexAubin commented Nov 22, 2018

Made a quick review, looks legit to me as well so merging as a micro decision.

Thanks again !

@alexAubin alexAubin merged commit 34878c2 into YunoHost:stretch-unstable Nov 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexAubin alexAubin added this to the 3.3.x milestone Nov 22, 2018

@airwoodix airwoodix deleted the airwoodix:fix-coding-style-ci-build branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment