[fix] _run_service_command was not properly returning False if comman…

…d failed (#616)
YunoHost · Jan 17, 2019 · bfe5056 · bfe5056
1 parent 808d844
commit bfe5056
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/yunohost/service.py b/src/yunohost/service.py
@@ -663,7 +663,7 @@ def _run_service_command(action, service):
     try:
         # Launch the command
         logger.debug("Running '%s'" % cmd)
-        p = subprocess.Popen(cmd.split(), stderr=subprocess.STDOUT)
+        p = subprocess.check_call(cmd.split(), stderr=subprocess.STDOUT)
         # If this command needs a lock (because the service uses yunohost
         # commands inside), find the PID and add a lock for it
         if need_lock: