Manage default application with DomainConfigPanel #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexAubin
approved these changes
Jan 14, 2022
[enh] makedefault with domain_config_set() [enh] Allow webadmin to reverse makedefault [legacy] translate legacy redirections to new domain config
This was referenced Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
yunohost app makedefault my_appis great!Fix YunoHost/issues#40
Solution
yunohost domain config set domain.tld feature.app.default_app -v myappor using the webadmin!Then it's generated in
app_ssowatconf, not inconf.json.persistentanymore.The redirection is updated when the app change url or is removed. ✨
I made
makedefaultuse the config system too so it's not broken o/PR Status
Tested locally and ready for reviews. 🎊
I'm not sure about the webadmin, I don't know what I'm doing with Vue but it-works! ™️
How to test
Using
ynh-dev, pull this PR and the yunohost-admin PR.cp /ynh-dev/yunohost/data/other/config_domain.toml /usr/share/yunohost/other/