Quickfixs #148
Closed
Quickfixs #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to make some tests, don't merge too quickly :$ |
| @@ -200,12 +194,13 @@ def domain_remove(auth, domain, force=False): | |||
| m18n.n('domain_uninstall_app_first')) | |||
|
|
|||
| if auth.remove('virtualdomain=' + domain + ',ou=domains') or force: | |||
| os.system('rm -rf /etc/yunohost/certs/%s' % domain) | |||
| shutil.rmtree('rm -rf /etc/yunohost/certs/%s' % domain) | |||
There was a problem hiding this comment.
Oops, it seems there is an issue here! :)
|
Thank you for this really big review!! :) We will have to see in which branch it should be merged... |
|
What is the status of this PR ? |
|
Probably too big and outdated now, I'm closing it and I'll redo one or a series of smaller one (or directly push on unstable if it's only things like pep8 which are just looks and not possible breaking things at a time where we don't have too much PRs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
A serie of quickfix I've made while reading this file (I wanted to know how domains were stored).
You can cherry-pick if you want.