Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger exception if string key aint defined during unit tests #261

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Trigger exception if string key aint defined during unit tests #261

merged 1 commit into from
Mar 11, 2017

Conversation

alexAubin
Copy link
Member

Feels dirty, but does the trick :s. Feel free to suggest a better way to do it. (I guess the proper way would be to tweak the moulinette directly)

Psycojoker
Psycojoker approved these changes Mar 1, 2017
View reviewed changes
Copy link
Member

@Psycojoker Psycojoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but the approach looks good to me since we better have tests than starting to refactor the moulinette before having them.

@Psycojoker Psycojoker added this to the 2.6.x milestone Mar 1, 2017
@alexAubin alexAubin mentioned this pull request Mar 1, 2017
Merged
@alexAubin
Copy link
Member Author

Two people, initiating merging in agreement with https://github.com/YunoHost/project-organization#tableau-r%C3%A9capitulatif-du-nombre-davis-n%C3%A9c%C3%A9ssaire-pour-la-prise-de-d%C3%A9cision

@alexAubin alexAubin merged commit df2f26c into unstable Mar 11, 2017
@M5oul M5oul deleted the trigger_exception_on_undefined_key_for_unit_tests branch March 11, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psycojoker Psycojoker Psycojoker approved these changes

Assignees
No one assigned
Labels
opinion needed
Projects
None yet
Milestone
2.6.x
3 participants
@alexAubin @Psycojoker @M5oul