Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Alow dash at the beginning of app settings #357

Merged
merged 1 commit into from Aug 30, 2017
Merged

[fix] Alow dash at the beginning of app settings #357

merged 1 commit into from Aug 30, 2017

Conversation

ariasuni
Copy link
Contributor

@alexAubin alexAubin changed the title [fix] Use --value="$3" syntax so that $3 can begin with a dash [fix] Alow dash at the beginning of app settings Aug 27, 2017
@alexAubin alexAubin added this to the 2.7 milestone Aug 27, 2017
@opi
Copy link
Contributor

opi commented Aug 28, 2017

nice catch !
IMHO, helpers should use long arguments anytime, to improve readability of code.

@Psycojoker Psycojoker merged commit dee1dee into YunoHost:unstable Aug 30, 2017
@Psycojoker
Copy link
Member

Thanks :)

@alexAubin alexAubin modified the milestones: 2.7, 2.7.x (fixes) or 2.8 Oct 12, 2017
@yunohost-bot yunohost-bot mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opi opi opi approved these changes

Assignees
No one assigned
Labels
opinion needed
Projects
None yet
Milestone
2.7.x
4 participants
@ariasuni @opi @Psycojoker @alexAubin