Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enh] Handle root path in nginx conf #361

Merged
merged 1 commit into from Sep 30, 2017
Merged

[enh] Handle root path in nginx conf #361

merged 1 commit into from Sep 30, 2017

Conversation

maniackcrudelis
Copy link
Contributor

Avoid to put a double slash when the path is /.
That can induce some errors in a nginx config.

@maniackcrudelis
[enh] Handle root path in nginx conf
dc3e465 
Avoid to put a double slash when the path is /.  
That can induce some errors in a nginx config.
JimboJoe
JimboJoe approved these changes Sep 20, 2017
View reviewed changes
Copy link
Member

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested with several apps with no side-effect.

@alexAubin alexAubin merged commit 220c447 into unstable Sep 30, 2017
@alexAubin alexAubin deleted the ynh_add_nginx_config_root_path branch September 30, 2017 11:01
@M5oul M5oul added this to the 2.7.x (fixes) or 2.8 milestone Sep 30, 2017
@maniackcrudelis maniackcrudelis mentioned this pull request Sep 5, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

Assignees
No one assigned
Labels
app helpers opinion needed
Projects
None yet
Milestone
2.7.x
4 participants
@maniackcrudelis @JimboJoe @alexAubin @M5oul