'/' was resulting in '//' in change_url

[Psycojoker]

Fix https://dev.yunohost.org/issues/999

Tested using "yunohost tools shell" and works as expected.

This seems to be quite blocking for the integration of change_url into apps according to feedback.

To test using "yunohost tools shell" do something like this:

$ yunohost tools shell
In [1]: from yunohost.app import normalize_url_path

In [2]: normalize_url_path("/")
Out[2]: '/'

In [3]: normalize_url_path("//")
Out[3]: '/'

In [4]: normalize_url_path("/////")
Out[4]: '/'

In [5]: normalize_url_path("a")                                                                                                                                                                                 
Out[5]: '/a/'

In [6]: normalize_url_path("qsd/qsd/qsd/")                                                                                                                                                                      
Out[6]: '/qsd/qsd/qsd/'

[opi]

probably nitpicking, but this helper could be in a file within the https://github.com/YunoHost/yunohost/tree/unstable/src/yunohost/utils folder ? (maybe out of scope of this PR)

[Psycojoker]

Probably. It would be ever greater in moulinette utils I think but that's mostly a "quick fix" PR to unblock the app group situation. I don't mind if we do those kind of modifications (as long as it don't block this PR for the next release) but I'm not super available for that now :x

[alexAubin]

Like this one ? 😉

yunohost/data/helpers.d/network

Lines 1 to 23 in 3571747

	# Normalize the url path syntax
	# Handle the slash at the beginning of path and its absence at ending
	# Return a normalized url path
	#
	# example: url_path=$(ynh_normalize_url_path $url_path)
	# ynh_normalize_url_path example -> /example
	# ynh_normalize_url_path /example -> /example
	# ynh_normalize_url_path /example/ -> /example
	# ynh_normalize_url_path / -> /
	#
	# usage: ynh_normalize_url_path path_to_normalize
	# | arg: url_path_to_normalize - URL path to normalize before using it
	ynh_normalize_url_path () {
	path_url=$1
	test -n "$path_url" || ynh_die "ynh_normalize_url_path expect a URL path as first argument and received nothing."
	if [ "${path_url:0:1}" != "/" ]; then # If the first character is not a /
	path_url="/$path_url" # Add / at begin of path variable
	fi
	if [ "${path_url:${#path_url}-1}" == "/" ] && [ ${#path_url} -gt 1 ]; then # If the last character is a / and that not the only character.
	path_url="${path_url:0:${#path_url}-1}" # Delete the last character
	fi
	echo $path_url
	}

[Psycojoker]

That doesn't great to call that from python :x

[alexAubin]

Ah nvm I was thinking @opi wanted to make this available for apps

[opi]

no, but not scoped in app.py ; But let's merge it now, and we'll cleanup later.

[JimboJoe]

LGTM and tested OK.