[enh] Remove date from sql dump #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opi
approved these changes
Sep 19, 2017
There was a problem hiding this comment.
Agreed; https://dev.mysql.com/doc/refman/5.7/en/mysqldump.html#option_mysqldump_dump-date for reference.
alexAubin
approved these changes
Sep 19, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Currently, if you make 2 successive dumps, their checksum will be different only because the dump dates are different.
So, you can't compare sql dumps.
Solution
Adding the
skip-dump-dateoption will remove this date in the sql dump.So, you can make a comparaison between 2 dumps by comparing their checksums.
You keep a date by the timestamp of the file.
PR Status
Tested on my own server with the fallback app.
Validation