Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fix this UnicodeDecodingError on backup-restore #375

Merged
merged 1 commit into from Sep 27, 2017
Merged

[fix] fix this UnicodeDecodingError on backup-restore #375

merged 1 commit into from Sep 27, 2017

Conversation

Psycojoker
Copy link
Member

Hello,

This fix the infamous UnicodeDecodeError that we have on backup-restore. Tested on a buggy backup, I can confirm that this is working.

This is worth a small release I think.

The problem was that we were returning unicode strings and trying to merge them against regular strings, I've fixed the problem at the source.

@Psycojoker Psycojoker added this to the 2.7.x (fixes) or 2.8 milestone Sep 25, 2017
M5oul
M5oul approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@M5oul M5oul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my side.

@M5oul
Copy link
Member

M5oul commented Sep 27, 2017

Could be merge soon.
And a release must be done just after.

@Psycojoker
Copy link
Member Author

Psycojoker commented Sep 27, 2017 •
edited

Hello,

In regards to:

  • the few number of people in positions to test this
  • the really small size of the patch
  • the importance (and urgence) of it
  • the confirmation that it works
  • I can't see how this can produce an opposition

I'm merging this. We can talk about releasing soon.

@Psycojoker Psycojoker merged commit f3c16e7 into unstable Sep 27, 2017
@Psycojoker Psycojoker deleted the backup-restore-UnicodeDecodeError branch September 27, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M5oul M5oul M5oul approved these changes

Assignees
No one assigned
Labels
important opinion needed
Projects
None yet
Milestone
2.7.x
2 participants
@Psycojoker @M5oul