Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enh] --verbose for backup during upgrade #432

Merged
merged 1 commit into from Feb 8, 2018
Merged

[enh] --verbose for backup during upgrade #432

merged 1 commit into from Feb 8, 2018

Conversation

maniackcrudelis
Copy link
Contributor

The problem

In case of usage of --verbose during upgrade, neither backup or restore will print their log.

Solution

Add --verbose to the backup and restore commands.

PR Status

Tested, ready to review.

How to test

Add a false at the end of an upgrade script.
And add --verbose to your upgrade.

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

alexAubin
alexAubin approved these changes Feb 4, 2018
View reviewed changes
Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 👍

@alexAubin alexAubin added this to the 2.7.x milestone Feb 4, 2018
@Psycojoker Psycojoker merged commit 62b3674 into unstable Feb 8, 2018
@Psycojoker Psycojoker deleted the backup_upgrade_verbose branch February 8, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexAubin alexAubin alexAubin approved these changes

Assignees
No one assigned
Labels
app helpers opinion needed
Projects
None yet
Milestone
2.7.x
3 participants
@maniackcrudelis @alexAubin @Psycojoker