New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metronome configuration file to v3.11 standard #559

Merged
merged 8 commits into from Oct 24, 2018

Conversation

Projects
None yet
4 participants
@maranda
Contributor

maranda commented Oct 13, 2018

The problem

Some now wanted features aren't loaded because Metronome uses a very old file

Solution

Conform configuration file to latest v3.11 release file, Metronome v3.11.x is best package or Metronome might throw a few (non-fatal) errors on startup

  • Principle agreement 1/2: @M5oul
  • Quick review 0/1:
  • Simple test 1/1: @M5oul
  • Deep review 1/1: @M5oul

maranda added some commits Oct 13, 2018

Update data/templates/metronome/metronome.cfg.lua
Conform configuration file to latest v3.11 release file, Metronome v3.11.x is best package or Metronome might throw a few (non-fatal) errors on startup

maranda added some commits Oct 13, 2018

@alexAubin alexAubin added this to the 3.x milestone Oct 13, 2018

@M5oul

M5oul approved these changes Oct 17, 2018 edited

Tested with Metronome 3.11.1.
Works perfectly.

@M5oul

This comment has been minimized.

Member

M5oul commented Oct 17, 2018

To test it on a production instance as root:

cd /usr/share/yunohost/templates/metronome
rm metronome.cfg.lua
wget https://raw.githubusercontent.com/YunoHost/yunohost/aa670058bdeda7067608c45a76e34aa1a73327d0/data/templates/metronome/metronome.cfg.lua
yunohost service regen-conf metronome --force

@M5oul M5oul modified the milestones: 3.x, 3.2.x Oct 17, 2018

@frju365

Works for me too. Tested in production.

maranda added some commits Oct 17, 2018

Update data/templates/metronome/metronome.cfg.lua
Add HTTP Upload service (moul's request), and fix indenting
Update data/templates/metronome/metronome.cfg.lua
Add privacy lists and simple blocking command between loaded modules
Update data/templates/metronome/metronome.cfg.lua
Comment websocket as lua-bitop is not installed by default
@M5oul

M5oul approved these changes Oct 17, 2018

@M5oul

This comment has been minimized.

Member

M5oul commented Oct 17, 2018

I don’t think:

sudo yunohost service regen-conf metronome --force

will happen.
Is there a way to run it automatically. Using a migration script?
It may erase some custom configurations.

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 19, 2018

I don’t think:

sudo yunohost service regen-conf metronome --force

will happen.
Is there a way to run it automatically. Using a migration script?
It may erase some custom configurations.

Is the --force needed here ? Won't it be regenerated by a simple regen-conf (which is done at every regular upgrade of the yunohost package) as long as the conf was not manually edited ?

@alexAubin

I don't have any strong opinion as I don't have much experience with XMPP. But since the feedback is good and it looks okay, I propose to merge this soon ?

@M5oul

This comment has been minimized.

Member

M5oul commented Oct 19, 2018

Is the --force needed here ? Won't it be regenerated by a simple regen-conf (which is done at every regular upgrade of the yunohost package) as long as the conf was not manually edited ?

Good question. Without the --force it wasn’t working. May be because I did change the configuration file. It could be a security avoiding custom configuration to be erased.

In case someone did modify this file, they won’t profit from all Metronome’s features.

@M5oul

This comment has been minimized.

Member

M5oul commented Oct 20, 2018

Ok, looks good to merge soon.
Concerning the regen-conf, I propose to notify people in the release annoncement that they can regenerate Metronome configuration with upper command to enable all the features.

@alexAubin alexAubin modified the milestones: 3.2.x, 3.3.x Oct 24, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Tested today and a regular regenconf was enough.

Yolomergin' /o/

@alexAubin alexAubin merged commit 62d72d6 into YunoHost:stretch-unstable Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment