New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Metronome configuration file to v3.11 standard #559
Update Metronome configuration file to v3.11 standard #559
Conversation
Conform configuration file to latest v3.11 release file, Metronome v3.11.x is best package or Metronome might throw a few (non-fatal) errors on startup
Finish updating
Add MUC avatars support
Fix whitespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Metronome 3.11.1.
Works perfectly.
To test it on a production instance as root: cd /usr/share/yunohost/templates/metronome
rm metronome.cfg.lua
wget https://raw.githubusercontent.com/YunoHost/yunohost/aa670058bdeda7067608c45a76e34aa1a73327d0/data/templates/metronome/metronome.cfg.lua
yunohost service regen-conf metronome --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too. Tested in production.
Add HTTP Upload service (moul's request), and fix indenting
Add privacy lists and simple blocking command between loaded modules
Comment websocket as lua-bitop is not installed by default
This reverts commit 3471eb7.
I don’t think: sudo yunohost service regen-conf metronome --force will happen. |
Is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any strong opinion as I don't have much experience with XMPP. But since the feedback is good and it looks okay, I propose to merge this soon ?
Good question. Without the In case someone did modify this file, they won’t profit from all Metronome’s features. |
Ok, looks good to merge soon. |
Tested today and a regular regenconf was enough. Yolomergin' /o/ |
The problem
Some now wanted features aren't loaded because Metronome uses a very old file
Solution
Conform configuration file to latest v3.11 release file, Metronome v3.11.x is best package or Metronome might throw a few (non-fatal) errors on startup