New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Change git clone for gitlab working with branch #615

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@Mickael-Martin
Copy link
Contributor

Mickael-Martin commented Jan 15, 2019

Ref : #605 -> Maybe you can close the orriginal pull request @alexAubin ?

Please check if you are no regression. It works for me with url of project : https://framagit.org/Mickael-Martin/zabbix_ynh or url of branch : https://framagit.org/Mickael-Martin/zabbix_ynh/tree/testing

The problem

Cannot import Gitlab (an other gitlab based solutions) project branch.

Solution

Use correct git syntax with correct url
Tested with Debian GNU/Linux 9

PR Status

...

How to test

test with many apps repo (github/gitlab/framagit/etc.)

Validation

--

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@alexAubin alexAubin referenced this pull request Jan 16, 2019

Closed

Patch import projet from Gitlab #605

0 of 4 tasks complete
@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 16, 2019

Ref : #605 -> Maybe you can close the orriginal pull request @alexAubin ?

Uh okay, we could have kept the whole thing on the original PR but that works too 😉

@alexAubin
Copy link
Member

alexAubin left a comment

To me that looks good 👍

@Mickael-Martin

This comment has been minimized.

Copy link
Contributor Author

Mickael-Martin commented Jan 16, 2019

Ref : #605 -> Maybe you can close the orriginal pull request @alexAubin ?

Uh okay, we could have kept the whole thing on the original PR but that works too wink

Yes but I don't know how make a new proposal of code with the same PR. It's more clear with a new for me ! ;-)

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 16, 2019

Yes but I don't know how make a new proposal of code with the same PR. It's more clear with a new for me ! ;-)

One PR = one branch, if you push new commits to the same branch, they automatically get added to the existing PR 😉

@alexAubin alexAubin changed the title Change git clone for gitlab working with branch [enh] Change git clone usage such that it works with gitlab Jan 17, 2019

@alexAubin alexAubin changed the title [enh] Change git clone usage such that it works with gitlab [enh] Change git clone for gitlab working with branch Jan 17, 2019

@alexAubin alexAubin merged commit 808d844 into YunoHost:stretch-unstable Jan 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment