Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of findDeep, Add missing field to IDeepEntry #85

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

casamia918
Copy link
Contributor

I fixed return type of findDeep and add context field to IDeepEntry interface.

But, for now, the type of parent field of IDeepEntry is not IDeepEntry. It is just same with parent.value.
It should be fix from the js source code, but I can't find where to fix it.

So I just add comment.

@YuriGor
Copy link
Owner

YuriGor commented Dec 25, 2020

Hi, thank you for PR.
parent arg should not be IDeepEntry.
findDeep returns same set of data as passing into iteratee
Here is a docs:
https://deepdash.io/#iteratee
"parentValue - an object or an array which contains current value"

@YuriGor YuriGor merged commit 3a109cc into YuriGor:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants