Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of colored option in README.md #177

Merged
merged 5 commits into from
May 1, 2022

Conversation

sahara-ooga
Copy link
Collaborator

@sahara-ooga sahara-ooga commented Apr 20, 2022

  • replace a image
    • I've replaced it with an example that gives a better overall picture of the coloring
  • go over sample code following the change of image

@sahara-ooga sahara-ooga added the documentation Improvements or additions to documentation label Apr 20, 2022
@sahara-ooga sahara-ooga marked this pull request as draft April 20, 2022 14:59
@sahara-ooga sahara-ooga self-assigned this Apr 20, 2022
@sahara-ooga sahara-ooga marked this pull request as ready for review April 20, 2022 15:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #177 (33f40b1) into main (e0485ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          13       13           
  Lines         528      528           
=======================================
  Hits          436      436           
  Misses         92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0485ac...33f40b1. Read the comment docs.

@sahara-ooga sahara-ooga merged commit 65b8a43 into main May 1, 2022
@sahara-ooga sahara-ooga deleted the feature/colored/improve-image branch May 1, 2022 05:47
@sahara-ooga sahara-ooga added this to the 1.3.0 The Heike Story milestone May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants