Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: occur infinity-loop when include @FocusState #182

Merged
merged 1 commit into from
May 18, 2022

Conversation

YusukeHosonuma
Copy link
Owner

@YusukeHosonuma YusukeHosonuma commented May 18, 2022

Occur infinity-loop in pretty-print when include @FocusState in target.
This PR is a temporary fix to prevent this issue.

//
// prettyPrint()
//
ContentView(
    email: "xxx@example.com",
    password: "pass",
    focus: <can not lookup>
)

//
// prettyPrintDebug()
//
ContentView(
    email: @State("xxx@example.com"),
    password: @State("pass"),
    focus: @FocusState(<can not lookup>)
)

@YusukeHosonuma YusukeHosonuma added the bug Something isn't working label May 18, 2022
Copy link
Collaborator

@sahara-ooga sahara-ooga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I hope we'll find fundamental solution in the near future.. :-)
I described the desire in the issue #183.

@sahara-ooga sahara-ooga added this to the 1.4.0 - TBD milestone May 18, 2022
@YusukeHosonuma
Copy link
Owner Author

Thanks for review!

@YusukeHosonuma YusukeHosonuma merged commit 2194aa9 into main May 18, 2022
@YusukeHosonuma YusukeHosonuma deleted the fix-focusstate branch May 18, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants