fix to make the string being attached to coloredLogStream colored again #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/Public/Pretty.swift
Outdated
Comment on lines
309
to
313
| let coloredOption: Option = { | ||
| var op = option | ||
| op.colored = true | ||
| return op | ||
| }() |
There was a problem hiding this comment.
Wouldn't a code like the following suffice?
Suggested change
| let coloredOption: Option = { | |
| var op = option | |
| op.colored = true | |
| return op | |
| }() | |
| let coloredOption = option | |
| coloredOption.colored = true |
There was a problem hiding this comment.
Swift compiler says for the suggested above:
cannot assign to property: 'coloredOption' is a 'let' constant
var is ok:
var coloredOption = option
coloredOption.colored = true
There was a problem hiding this comment.
Oops, I wrong.
Use var instead of let is corrected.
There was a problem hiding this comment.
@YusukeHosonuma
I've refactored in 7582ec5.
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug caused in PR #165 and #173 where strings for
output-colored.logwere no longer colored.this fixes #184.