Welcome: format option #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeHosonuma
force-pushed
the
welcome/format-option
branch
from
4c3e21e
to
c4f2877
Compare
YusukeHosonuma
commented
Feb 21, 2020
| /// - target: target | ||
| /// - debug: Enable debug-level output if `true` (like `debugPrint`) | ||
| /// - pretty: Enable pretty output if `true` | ||
| func string<T: Any>(_ target: T, debug: Bool, pretty: Bool) -> String { |
There was a problem hiding this comment.
Rename elementString to string.
YusukeHosonuma
commented
Feb 21, 2020
Comment on lines
+10
to
+16
| func _string(_ target: Any) -> String { | ||
| string(target, debug: debug, pretty: pretty) // fixed `debug` and `pretty` | ||
| } | ||
|
|
||
| func _value(_ target: Any) -> String { | ||
| valueString(target, debug: debug) // fixed `debug` | ||
| } |
There was a problem hiding this comment.
Add local function that fixed arguments debug and pretty.
YusukeHosonuma
commented
Feb 21, 2020
Comment on lines
+40
to
+41
| let label = _value(key) | ||
| let value = _string(val).indentTail(size: "\(label): ".count) |
There was a problem hiding this comment.
Change call to local function _value and _string here and other.
YusukeHosonuma
commented
Feb 21, 2020
| @@ -0,0 +1,147 @@ | |||
| class Pretty { | |||
| private var indent: Int { Debug.option.indent } | |||
There was a problem hiding this comment.
This is alias for Debug.option.indent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
Optionstruct that representformat-optionsuch asindent-size.And some refactors :)
TODO
master