Use reflection instead of hardcoded names to copy object LDAPConnecti…

…on, to avoid misses/errors
Yvand · Apr 10, 2019 · 24b86c0 · 24b86c0
1 parent 6017579
commit 24b86c0
Showing 1 changed file with 24 additions and 17 deletions.
diff --git a/LDAPCP/LDAPCPConfig.cs b/LDAPCP/LDAPCPConfig.cs
@@ -796,24 +796,31 @@ public LDAPConnection()
 
         internal LDAPConnection CopyPublicProperties()
         {
-            return new LDAPConnection()
+            LDAPConnection copy = new LDAPConnection();
+            FieldInfo[] publicFields = this.GetType().GetFields(BindingFlags.Public | BindingFlags.Instance);
+            foreach (FieldInfo field in publicFields)
             {
-                Id = this.Id,
-                Path = this.Path,
-                Username = this.Username,
-                Password = this.Password,
-                Metadata = this.Metadata,
-                AuthenticationTypes = this.AuthenticationTypes,
-                UserServerDirectoryEntry = this.UserServerDirectoryEntry,
-                AugmentationEnabled = this.AugmentationEnabled,
-                GetGroupMembershipAsADDomain = this.GetGroupMembershipAsADDomain,
-                GroupMembershipAttributes = this.GroupMembershipAttributes,
-                Directory = this.Directory,
-                Filter = this.Filter,
-                DomainName = this.DomainName,
-                DomainFQDN = this.DomainFQDN,
-                RootContainer = this.RootContainer,
-            };
+                field.SetValue(copy, field.GetValue(this));
+            }
+            return copy;
+            //return new LDAPConnection()
+            //{
+            //    Id = this.Id,
+            //    Path = this.Path,
+            //    Username = this.Username,
+            //    Password = this.Password,
+            //    Metadata = this.Metadata,
+            //    AuthenticationTypes = this.AuthenticationTypes,
+            //    UserServerDirectoryEntry = this.UserServerDirectoryEntry,
+            //    AugmentationEnabled = this.AugmentationEnabled,
+            //    GetGroupMembershipAsADDomain = this.GetGroupMembershipAsADDomain,
+            //    GroupMembershipAttributes = this.GroupMembershipAttributes,
+            //    Directory = this.Directory,
+            //    Filter = this.Filter,
+            //    DomainName = this.DomainName,
+            //    DomainFQDN = this.DomainFQDN,
+            //    RootContainer = this.RootContainer,
+            //};
         }
     }