Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application icon specified in a userModule is not displayed #242

Closed
pz1 opened this issue May 22, 2015 · 11 comments
Closed

Application icon specified in a userModule is not displayed #242

pz1 opened this issue May 22, 2015 · 11 comments

Comments

@pz1
Copy link
Contributor

pz1 commented May 22, 2015

In my Wunderground module I have specified in module.json an icon (png), that is stored in the htdocs folder of that userModule. This icon is not displayed in the Smarthome UI of rc29. Even if I rename the icon to icon.png like it is done in the standard modules, there is still nothing displayed in the apps view of smarthome.
@ronie-z-wave
Copy link
Contributor

Hmm usually it should work ... did you create/edit the icon with windows paint? I know that sounds strange, but I've run into the same issue with that tool. Use instead for example gimp or infranview ... If not then I have to debug it :)

@pz1
Copy link
Contributor Author

pz1 commented May 22, 2015

This Wunderground icon was taken from their website. I don't know how they made it.
The icon for my Solar Quality of Service module was mad by myself in Win7 with the program Paint.NET not Windows Paint!

@ronie-z-wave
Copy link
Contributor

ok, but the other one works?

@pz1
Copy link
Contributor Author

pz1 commented May 22, 2015

Sorry, both don't work

@ronie-z-wave
Copy link
Contributor

Ok, I'll try to find out what the problem is.

@pz1
Copy link
Contributor Author

pz1 commented May 22, 2015

In the meantime I did move the working OpenRemote icon to my Wunderground userModule. Nothing shows up. There still may be somthing wrong with my icons, but it definitely seems that icons in the usermodules/htdocs folder are not seen.
I'll wait and see. Thanks for your attention.

@ronie-z-wave
Copy link
Contributor

argh, sry ...
For the module upload (comes with store in near future) I've added a new param "moduleName" to all module.json's so that we know the correct name for adding and extracting in new folder beneath /usermodules cause 'id' and 'classname' are added by AM-controller after initialization ... So you can solve this by adding this parameter. Nevertheless I think it will be good to have a fallback, e.g. using id or classname instead ... We'll change this ;)

@pz1
Copy link
Contributor Author

pz1 commented May 26, 2015

Oh eternal joy :)
Thanks; that did the trick! Not a bad idea to add the module name to the module.json file.
(Would be nice if we had a reference document somrwhere decribing all obligatory and optional JSON elements)

@ronie-z-wave
Copy link
Contributor

I think during a quite minute I'll try to add this to our wiki: https://github.com/Z-Wave-Me/home-automation/wiki

@pz1
Copy link
Contributor Author

pz1 commented May 26, 2015

I just documented this on the forum

@ronie-z-wave
Copy link
Contributor

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pz1 @ronie-z-wave