Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different parsing strategies #4205

Merged
merged 4 commits into from
May 4, 2020
Merged

Conversation

i-walker
Copy link
Contributor

@i-walker i-walker commented May 4, 2020

the java API only allows parsing Strings to Arrays of BoolExpr, but the ASTVector can also parse to other types like, IntExpr, RealExpr etc.
To allow that those constructors and funtion nCtx() need to be public

@msftclas
Copy link

msftclas commented May 4, 2020

CLA assistant check
All CLA requirements met.

@i-walker
Copy link
Contributor Author

i-walker commented May 4, 2020

@NikolajBjorner may you help me why the Build CI tasks all fail?

@NikolajBjorner
Copy link
Contributor

@NikolajBjorner may you help me why the Build CI tasks all fail?

Your code is not type correct.
BoolExpr[] is not the same as an ASTVector.
The previous version of the code converts the ASTVector to the type specified in the prototype.

@NikolajBjorner NikolajBjorner merged commit be998c3 into Z3Prover:master May 4, 2020
@i-walker
Copy link
Contributor Author

i-walker commented May 4, 2020

Thanks @NikolajBjorner I'll add the remaining functions in the next PR :)

hgvk94 pushed a commit to hgvk94/z3 that referenced this pull request May 7, 2020
* modifiers

* modifiers and function

* revert

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants