Downgrade arm cross compile toolchain to glibc 2.34 #7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discover the most recent toolchain is built against glibc 2.36, this will defeat the purpose of manylinux. (too new)
I find a lower version that is built against glibc 2.34.
The original pypa-manylinux_2014 is built against glibc 2.17 but that is going to EOL by 2024-06-30.
The really old ARM toolchain has its own pain, so let's settle for glibc 2.34 for cross compiling.
I also plumb the correct glibc information during packaging so it reflect the version from the cross compile toolchain.
Bonus fix: native host aarch64 compiling, so those that need to build their own wheel can easily fire up the container on their own arch to build custom wheel in their own package repository.