Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lazy Loading in Model Strict Mode #96

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

Z3d0X
Copy link
Owner

@Z3d0X Z3d0X commented Sep 25, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Sep 25, 2023

PR Summary

  • Simplification of Page Retrieval
    The method getPageUrls found within our file FilamentFabricatorManager.php has been adjusted. Originally, this method was scanning for both direct and indirect descendants of pages. We've streamlined this process; it now only looks for all descendants, regardless of their level, improving the efficiency of page searches.

  • Improved Iteration over Page Descendants
    In our FilamentFabricatorManager.php file, there are changes to the setPageUrl method. This method used to cycle through only direct descendants of a page. Now, it considers all descendants, enhancing the thoroughness of our page URL setting process.

  • Child Page Management in Page.php
    We've updated the management of child pages in our Page.php file. The allChildren method used to exclude some child pages in its retrieval process. It now includes all child pages, enhancing our ability to manage these pages effectively.

@Z3d0X
Copy link
Owner Author

Z3d0X commented Sep 25, 2023

@danielbehrendt could you verify this works

@danielbehrendt
Copy link
Contributor

Yes, I could verify that this is working. I don't receive any errors.

@Z3d0X Z3d0X added the bug Something isn't working label Sep 25, 2023
@Z3d0X
Copy link
Owner Author

Z3d0X commented Sep 25, 2023

Awesome thanks for the quick reply

@Z3d0X Z3d0X mentioned this pull request Sep 25, 2023
@Z3d0X Z3d0X merged commit bbdeac1 into 2.x Sep 25, 2023
5 checks passed
Z3d0X added a commit that referenced this pull request Sep 25, 2023
@Z3d0X Z3d0X deleted the bugfix/lazy-loading-fix branch October 14, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants