Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags for Doom and Heretic monsters #512

Merged
merged 1 commit into from Jun 27, 2018

Conversation

mmaulwurff
Copy link
Contributor

@mmaulwurff mmaulwurff commented Jun 24, 2018

Why? So mods that reveal enemy names don't show internal monster class names.

Tags are based on language.enu lump obituaries.

Copy link
Member

@coelckers coelckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is supposed for printing it's better not to make the names all-capitals. There are fonts that contain both uppercase and lowercase letters, just look at the console font as an example.
The names should reflect that.

Copy link
Collaborator

@alexey-lysiuk alexey-lysiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please squash all changes to one commit?

Why? So mods that reveal enemy names don't show internal monster class names.

Tags are based on language.enu lump:
- Tags for Doom/Doom 2 monsters are referring directly to CC_* strings.
- Tags for Heretic monsters are based on obituaries.
- All tags match corresponding obituaries.
@mmaulwurff mmaulwurff force-pushed the monster-tags branch 2 times, most recently from e101a46 to 5e4d3a3 Compare June 25, 2018 14:44
@mmaulwurff
Copy link
Contributor Author

Done (not without a misstep or two in the process).

@coelckers coelckers merged commit 97aba0c into ZDoom:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants