Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

fix change event of Record Type #25

Merged
merged 1 commit into from
Dec 13, 2018
Merged

fix change event of Record Type #25

merged 1 commit into from
Dec 13, 2018

Conversation

huihuimoe
Copy link

No description provided.

@ZE3kr ZE3kr added the enhancement New feature or request label Dec 12, 2018
@ZE3kr ZE3kr self-assigned this Dec 12, 2018
@ZE3kr
Copy link
Owner

ZE3kr commented Dec 13, 2018

Is there any significant changes between onchange and addEventListener('change', ? Also in your new pull request #26 it still uses onchange. Should it also be changed to addEventListener?

@ZE3kr ZE3kr self-requested a review December 13, 2018 05:24
@huihuimoe
Copy link
Author

I write a demo for their difference.

https://jsfiddle.net/jzygt1nk/

Only the lastest handler of onchange can be triggered.

See the link below for detail.

https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onclick#Notes

Also in your new pull request #26 it still uses onchange. Should it also be changed to addEventListener?

Yep. It's my miss.

@ZE3kr ZE3kr merged commit 2604703 into ZE3kr:develop Dec 13, 2018
@ZE3kr ZE3kr removed their request for review December 13, 2018 11:03
ZE3kr added a commit that referenced this pull request Apr 29, 2020
fix change event of Record Type
ZE3kr added a commit that referenced this pull request Apr 29, 2020
fix change event of Record Type
ZE3kr added a commit that referenced this pull request Apr 29, 2020
fix change event of Record Type
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants