New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Zeppelin web build #296
Conversation
New version of eirslett/frontend-maven-plugin implements running bower and running grunt so this PR take advantage of it which simplifies pom.xml |
For the issue #295, the root pom is a mess and it is really hard to understand what is going on there and the
For me it is totally fine because
Now the webapp only need Any advice or cleaner way to solve this issue? |
Well I think this PR is ready to go. @Leemoonsoo can you take a look and tell me whats bother you? |
Just for the sport:
|
Can someone review this PR? |
Great. It works perfectly for me, but let me test little bit more with different conditions. |
@Leemoonsoo sure. |
Tested on Mac OSX after git clean and bower/node cache cleaned, worked well even though I don't get the same compilation speed (2:35:271 for me), but it is clearly faster and there is no duplicate anymore on the web part |
@corneadoug of course the build 'speed' will depends on your hardware :) |
Tested with non-root / root user. with/without build-distr. Great work! LGTM! |
So it is good to be merge? |
I think it's good to go. |
Fix Zeppelin web build
This PR is about simplifying the pom (by updating the frontend-maven-plugin plugin) plus doesn't reinstall node, npm and bower components for every build.
Fix also the imagemin error
lib64/libc.so.6: version GLIBC_2.XX' not found
on Linux