Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zeppelin web build #296

Merged
merged 10 commits into from Jan 27, 2015
Merged

Fix Zeppelin web build #296

merged 10 commits into from Jan 27, 2015

Conversation

anthonycorbacho
Copy link
Contributor

This PR is about simplifying the pom (by updating the frontend-maven-plugin plugin) plus doesn't reinstall node, npm and bower components for every build.

Fix also the imagemin error lib64/libc.so.6: version GLIBC_2.XX' not found on Linux

@bzz
Copy link

bzz commented Jan 22, 2015

New version of eirslett/frontend-maven-plugin implements running bower and running grunt so this PR take advantage of it which simplifies pom.xml
Looks great to me!

@anthonycorbacho
Copy link
Contributor Author

For the issue #295, the root pom is a mess and it is really hard to understand what is going on there and the pluginManagement somehow trigger the webapp to be build 2 time.
The only way I found is to comment out the

 <parent>
    <artifactId>zeppelin</artifactId>
    <groupId>com.nflabs.zeppelin</groupId>
    <version>0.5.0-SNAPSHOT</version>
  </parent>

For me it is totally fine because

  • Zeppelin web app is self contain and doest require any dependency from the parent
  • Zeppelin web already have a checkstyle (JSHints)

Now the webapp only need ~54s to build.....

Any advice or cleaner way to solve this issue?

@anthonycorbacho
Copy link
Contributor Author

Well I think this PR is ready to go.
I tested it againts OSX, centOS 6.5 and Ubuntu and compilation worked fine.
Also updated the readme file.

@Leemoonsoo can you take a look and tell me whats bother you?

@anthonycorbacho
Copy link
Contributor Author

Just for the sport:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Zeppelin .......................................... SUCCESS [2.208s]
[INFO] Zeppelin: Zengine ................................. SUCCESS [3.153s]
[INFO] Zeppelin: Spark ................................... SUCCESS [2.585s]
[INFO] Zeppelin: Markdown interpreter .................... SUCCESS [1.226s]
[INFO] Zeppelin: Shell interpreter ....................... SUCCESS [1.134s]
[INFO] Zeppelin: web Application ......................... SUCCESS [53.121s]
[INFO] Zeppelin: Server .................................. SUCCESS [2.950s]
[INFO] Zeppelin: Packaging distribution .................. SUCCESS [0.297s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:06.917s
[INFO] Finished at: Thu Jan 22 20:53:08 KST 2015
[INFO] Final Memory: 53M/669M
[INFO] ------------------------------------------------------------------------

@anthonycorbacho anthonycorbacho mentioned this pull request Jan 23, 2015
@anthonycorbacho
Copy link
Contributor Author

Can someone review this PR?

@Leemoonsoo
Copy link
Contributor

Great. It works perfectly for me, but let me test little bit more with different conditions.

@anthonycorbacho
Copy link
Contributor Author

@Leemoonsoo sure.

@corneadoug
Copy link
Contributor

Tested on Mac OSX after git clean and bower/node cache cleaned, worked well even though I don't get the same compilation speed (2:35:271 for me), but it is clearly faster and there is no duplicate anymore on the web part

@anthonycorbacho
Copy link
Contributor Author

@corneadoug of course the build 'speed' will depends on your hardware :)

@Leemoonsoo
Copy link
Contributor

Tested with non-root / root user. with/without build-distr. Great work! LGTM!

@anthonycorbacho
Copy link
Contributor Author

So it is good to be merge?

@Leemoonsoo
Copy link
Contributor

I think it's good to go.

anthonycorbacho added a commit that referenced this pull request Jan 27, 2015
@anthonycorbacho anthonycorbacho merged commit c0f14c4 into master Jan 27, 2015
@anthonycorbacho anthonycorbacho deleted the fix/webClientBuild branch January 27, 2015 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants