Swap Image for <img /> when loading from Wagtail #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many images are coming from Wagtail and (I think?) cannot be loaded with next/image unless the image is available at compile time. I'm swapping out `Image` for plain `<img />` tags for now, in hope that this allows the images to be loaded from Wagtail. Ref #140
mattijsstam
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many images are coming from Wagtail and (I think?) cannot be loaded with next/image unless the image is available at compile time. I'm swapping out
Imagefor plain<img />tags for now, in hope that this allows the images to be loaded from Wagtail.This fixes when images are loaded as part of a
TextAndMediablock, or in aCardblock, but does not fix if you try to embed an image as part of the rich text for a page. In that case, Wagtail is returning an<embed />tag which isn't useful. It doesn't even include ansrcattribute. Is this something that can be fine-tuned in Wagtail?Ref #140