Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

138 optimize frontend code regarding react hooks #151

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

broekhuisg
Copy link
Collaborator

A few fixes and tweaks after the site went to the server:

Images on server not loading 
Unneed usage of react hooks fixed
Grid layout not everywhere available fixed
Pagewrap on staticpage 
TextMedia remove title/size:
TextMedia and Section block frontend moved to blocks folder, same structure as the backend has
Backgroundcolor en size of the background options added to the blocks, front- and backend

@broekhuisg broekhuisg linked an issue Nov 8, 2022 that may be closed by this pull request
antw
antw previously approved these changes Nov 8, 2022
Copy link
Contributor

@antw antw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. 👍

Thanks for improving <img />Image

@broekhuisg broekhuisg merged commit d2d70c7 into main Nov 9, 2022
@broekhuisg broekhuisg deleted the 138-optimize-frontend-code-regarding-react-hooks branch November 9, 2022 08:48
@pascalalferink
Copy link
Collaborator

While I was reviewing this request, this branch was merged.
I had two remarks, I put them in two issues:
#152
#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize frontend code regarding React Hooks
4 participants