Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Drop dependency on ZfcBase #560

Open
adamlundrigan opened this issue Jan 26, 2015 · 6 comments
Open

[RFC] Drop dependency on ZfcBase #560

adamlundrigan opened this issue Jan 26, 2015 · 6 comments

Comments

@adamlundrigan
Copy link
Contributor

With ZfcUser 2.0 targeting PHP 5.5 we can eliminate the need for ZfcBase:

  • Refactor of mapper layer ([RFC] Simplifying the mapper layer #559) eliminates dependency on AbstractDbMapper and MasterSlaveAdapter
  • Being able to use traits eliminates the need for EventProvider, ProvidesEventsForm, ProvidesEventsInputFilter, as ZF2 bundles an EventManagerAwareTrait for this purpose
  • No sane person should be using AbstractModule; ZfcUser itself hasn't used it in quite some time.

And that's the sum total of what ZfcBase provides.

@Danielss89
Copy link
Member

Agree, no need for ZfcBase with 5.5 and #559.

@telkins
Copy link

telkins commented Jun 29, 2016

Is anyone working on this? I may be wrong, but it appears to be necessary in order to resolve #642 ZF3 Compatibility.

@stijnhau
Copy link

If we merge my refactoring of dev master we dropped the need of zfcBase.
With @Danielss89 changes for version 2.x we cureenlty duplicate those code to prevent BC breakes

@stijnhau
Copy link

@Danielss89 I think this can be closed

@adamlundrigan
Copy link
Contributor Author

This file has a ZfcBase namespace:
https://github.com/ZF-Commons/ZfcUser/blob/3.x/src/ZfcUser/Db/Adapter/MasterSlaveAdapter.php

The README.md still lists ZfcBase as a dependency (but composer.json doesn't)

@adamlundrigan adamlundrigan reopened this May 26, 2017
@stijnhau
Copy link

But is that namespoace still needed cant' we just rename it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants