Enhancement: Update squizlabs/php_codesniffer and run phpcs before phpunit #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, what? This shouldn't pass.
/cc @EvanDotPro |
Closed
localheinz
changed the title
localheinz
changed the title
|
Blocked by #543. |
localheinz
force-pushed
the
feature/phpcs
branch
from
318cf9f
to
22b7535
Compare
localheinz
changed the title
|
On Travis:
There's not even any output generated. See https://travis-ci.org/ZF-Commons/ZfcUser/jobs/41857420#L175. |
localheinz
force-pushed
the
feature/phpcs
branch
from
5922964
to
127f078
Compare
|
@localheinz Yeah, i don't see any output(report) in travis at all. Something is going on with the command. |
localheinz
force-pushed
the
feature/phpcs
branch
from
127f078
to
ae8014a
Compare
|
There's not much of a difference to https://github.com/zendframework/modules.zendframework.com/blob/master/.travis.yml#L11, is there? |
|
@localheinz it seems to me that we reached green here: does that mean that we should merge? |
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
|
Not yet green, see this commit localheinz@ae8014a and the comments above. |
|
Closing since I've come to prefer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
squizlabs/php_codesnifferphpcs.xmlfor configuringphpcsphpcsbeforephpuniton TravisSomewhat related to zendframework/zendframework#6182.