Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic fix for the rounding heuristic of the Probability Simplex #175

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

dhendryc
Copy link
Collaborator

In the hyperplane-aware rounding heuristic for the Probability Simplex, it can happen that the rounded point as all zero entries for the integer variables. In which case, we just return the point but let the feasibility check run.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (ee5cc6c) 86.23% compared to head (9145f03) 87.17%.
Report is 14 commits behind head on main.

Files Patch % Lines
src/polytope_blmos.jl 90.16% 6 Missing ⚠️
src/MOI_bounded_oracle.jl 87.50% 4 Missing ⚠️
src/callbacks.jl 50.00% 4 Missing ⚠️
src/heuristics.jl 96.15% 3 Missing ⚠️
src/node.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   86.23%   87.17%   +0.94%     
==========================================
  Files          17       18       +1     
  Lines        1482     1622     +140     
==========================================
+ Hits         1278     1414     +136     
- Misses        204      208       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/polytope_blmos.jl Outdated Show resolved Hide resolved
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
@dhendryc dhendryc merged commit 4746330 into main Jan 30, 2024
5 checks passed
@dhendryc dhendryc deleted the heu-fix branch January 30, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants