Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add definitions for bit timings and remove emergencyStop API #12

Merged
merged 1 commit into from
May 7, 2024

Conversation

higaski
Copy link
Contributor

@higaski higaski commented May 7, 2024

Huge refactoring which also adds definition for bit timings (necessary because of buggy non standard complient Lenz LG100):

  • Add datagram method to rx::bidi::CrtpBase to queue dyn (ID7) datagrams
  • Replace int32_t direction (1, -1) with bool (1, 0)
  • Remove decoders emergencyStop API and replace it with speed(-1)
  • Add Direction and Speed enumerations
  • Rename bidi::Speed to bidi::Kmh to avoid ambiguity
  • Rename tx::Config::preamble_bits to num_preamble to match RMT configuration

@higaski higaski merged commit 18c8f15 into master May 7, 2024
3 checks passed
@higaski higaski deleted the dyn branch May 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant