Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing uncaught stream event error in case of multiples piped stream #27

Merged
merged 1 commit into from Feb 9, 2017
Merged

Fixing uncaught stream event error in case of multiples piped stream #27

merged 1 commit into from Feb 9, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2017

When using a stream chain like

var a = createStream();
a.pipe(b).pipe(c);

this specific error is not caught and cause the whole app to crash.

@ZJONSSON
Copy link
Owner

ZJONSSON commented Feb 9, 2017

Good catch, thanks!! Error handling gets a little bit tricky as we have two types of streams here, the individual files (entriy) and then the stream that is piping the entries down. For FILE_ENDED I think your fix makes sense. We might have to make adjustments for ParseOne which returns only the entry stream

@ZJONSSON ZJONSSON merged commit 2c2edb1 into ZJONSSON:master Feb 9, 2017
@ZJONSSON
Copy link
Owner

ZJONSSON commented Feb 9, 2017

Published on npm as + unzipper@0.8.4

@ghost
Copy link
Author

ghost commented Feb 9, 2017

Thank you for the fast merge!
I will look into ParseOne later, i might need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant