Provide the readInt8 function call in plain_dictionary codec with arguments #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
codec/plain_dictionary.js
, we are calling:readInt8()
without argument:This is fine for
node.js
, because itsreadInt8()
method has a default argument ofoffset = 0
. See https://github.com/nodejs/node/blob/master/lib/internal/buffer.js#L411.But when using this package in browser, it breaks because the buffer method (provided by shim packages) does not have such a default argument. For example: https://github.com/feross/buffer/blob/master/index.js#L1221
Accepting this change will make this package compatible to use in browser.