fromPrimitive_TIMESTAMP_MILLIS BigInt issue #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
alietors
added a commit
to alietors/parquetjs
that referenced
this pull request
Jun 22, 2021
We found that parquet files created from pyarrow have "unconventional" format for millis and micros. This change is not original it's a merge of 2 already proposed PRs ZJONSSON#65 ZJONSSON#45 We are struggling with those issues, it this something you will consider to merge? we can create our own fork but we believe is better having one library.
wilwade
added a commit
to LibertyDSNP/parquetjs
that referenced
this pull request
May 12, 2022
wilwade
added a commit
to LibertyDSNP/parquetjs
that referenced
this pull request
May 12, 2022
* Clean up TIMESTAMP issues ZJONSSON#65 ZJONSSON#45 * Use MAX_SAFE_INTEGER for testing toPrimitive_TIME_MILLIS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent fromPrimitive_TIMESTAMP_MILLIS from passing a BigInt to the Date constructor, which it does on Node 12