fixed a corner case when ||g(x_0)|| is exactly zero

ZJU-FAST-Lab · Nov 24, 2022 · a96c50e · a96c50e
1 parent dc0e4cb
commit a96c50e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/include/lbfgs.hpp b/include/lbfgs.hpp
@@ -532,7 +532,7 @@ namespace lbfgs
         gnorm_inf = g.cwiseAbs().maxCoeff();
         xnorm_inf = x.cwiseAbs().maxCoeff();
 
-        if (gnorm_inf / std::max(1.0, xnorm_inf) < param.g_epsilon)
+        if (gnorm_inf / std::max(1.0, xnorm_inf) <= param.g_epsilon)
         {
             /* The initial guess is already a stationary point. */
             ret = LBFGS_CONVERGENCE;
@@ -554,7 +554,7 @@ namespace lbfgs
                 xp = x;
                 gp = g;
 
-                /* If the step bound can be provied dynamically, then apply it. */
+                /* If the step bound can be provided dynamically, then apply it. */
                 step_min = param.min_step;
                 step_max = param.max_step;
                 if (cd.proc_stepbound)