修复Windows下链接OpenSSL静态库缺少Crypt32库问题 #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasphin
reviewed
May 21, 2024
| @@ -403,6 +403,8 @@ if(OPENSSL_FOUND AND ENABLE_OPENSSL) | |||
| update_cached_list(MK_LINK_LIBRARIES ${OPENSSL_LIBRARIES}) | |||
| if(CMAKE_SYSTEM_NAME MATCHES "Linux" AND OPENSSL_USE_STATIC_LIBS) | |||
| update_cached_list(MK_LINK_LIBRARIES ${CMAKE_DL_LIBS}) | |||
| elseif(CMAKE_SYSTEM_NAME MATCHES "Windows" AND OPENSSL_USE_STATIC_LIBS) | |||
| update_cached_list(MK_LINK_LIBRARIES Crypt32) | |||
There was a problem hiding this comment.
部分环境下貌似不需要，实际上，openssl 的依赖应该由 FindOpenSSL 提供。
There was a problem hiding this comment.
部分环境下貌似不需要，实际上，openssl 的依赖应该由 FindOpenSSL 提供。
看起来没啥副作用 也不是c/c++代码 由于我没windows环境 就直接合了
There was a problem hiding this comment.
目前我测试使用的是在slproweb这个网站提供的openssl安装包安装后的VC静态库链接时出现上面的问题，目前windows全静态编译下来生成的mk_api.dll大小在11m这样，如果自己编译的openssl可能没有这个问题，不过openssl编译确实有点麻烦。
There was a problem hiding this comment.
目前我测试使用的是在slproweb这个网站提供的openssl安装包安装后的VC静态库链接时出现上面的问题，目前windows全静态编译下来生成的mk_api.dll大小在11m这样，如果自己编译的openssl可能没有这个问题，不过openssl编译确实有点麻烦。
There was a problem hiding this comment.
之前确实在不同环境上发现有的需要加有的不需要，可以先这样。一般在使用cmake管理依赖情况下应该由cmake去保证依赖完整，cmake也会有问题，更新起来没直接项目改快
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复Windows下链接OpenSSL静态库缺少Crypt32库问题