Cookiecutter Template Branch Customizable + zoo-calrissian-runner dependency update #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoo-project-dru: Cookiecutter Template Branch Customizable
Overview
This pull request enhances the
zoo-project-dru
Helm chart values by allowing the specification of a Git branch when setting thecookiecutter
template URL. This addition offers flexibility in choosing the branch from which to clone the cookiecutter template. If no branch is specified, it will default to 'master'.For instance:
Changes Made
DeployProcess.py
(
zoo-project/zoo-services/utils/open-api/dru/DeployProcess.py
):_get_conf_value_if_exists
that retrieves a configuration value and returnsNone
if the configuration does not exist.git clone
command to set the branch if thetemplateBranch
configuration property is specified.Testing
Testing Plan
To verify this feature:
ZooProject-DRU
on Minikube's Docker registry:zoo-project-dru/values_minikube.yaml
of thezoo-project-dru
Helm chart, set the tag of the new Docker image:cookiecutter
section inzoo-project-dru/values_minikube.yaml
by specifying the branch:zoo-project-dru
Helm chart:Deploy a service.
Access the
zoofpm
pod, navigate to the deployed services folder, and confirm that the service deployed in the previous step was generated using the cookiecutter template from the 'zoo-project-dru' branch.zoo-project-dru: Update of zoo-calrissian-runner dependency
Zoo-calrissian-runner version 0.1.8 has better support for inputs passed by the zoo-kernel, in particular for those of type array.
Related Issue / Discussion
ZOO-Project/charts#7
Additional Information
Contributions and Licensing
(as per https://zoo-project.github.io/docs/contribute/howto.html#licensing)