Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
hestiaHUGO: fixed button not handling overflowing condition bug
Browse files Browse the repository at this point in the history
Appearently, the button is not handling the overflowing condition
properly due to multiple properties used (overflow-wrap + word-break).
Hence, we need to fix it.

This patch fixes button not handling overflowing condition bug in
hestiaHUGO/ directory.

Co-authored-by: Shuralyov, Jean <jean.shuralyov@proton.me>
Co-authored-by: Galyna, Cory <cory.galyna@zoralab.com>
Co-authored-by: (Holloway) Chew, Kean Ho <kean.ho.chew@zoralab.com>
Signed-off-by: (Holloway) Chew, Kean Ho <kean.ho.chew@zoralab.com>
  • Loading branch information
3 people committed Jul 12, 2023
1 parent c8cf5e4 commit 746a8c2
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 15 deletions.
2 changes: 0 additions & 2 deletions hestiaHUGO/layouts/partials/hestiaGUI/zoralabANCHOR/ToCSS
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ a {
text-decoration: var(--anchor-text-decoration);
text-transform: var(--anchor-text-transform);
overflow-wrap: var(--anchor-overflow-wrap);
word-break: var(--anchor-word-break);
letter-spacing: var(--anchor-letter-spacing);
line-height: var(--anchor-line-height);
text-align: var(--anchor-text-align);
Expand Down Expand Up @@ -86,7 +85,6 @@ a.prestige {
@media print {
a {
overflow-wrap: var(--anchor-overflow-wrap-print) !important;
word-break: var(--anchor-overflow-word-break) !important;

color: var(--anchor-color-print) !important;
border-color: var(--anchor-color-print) !important;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
"--anchor-text-transform" = "normal"
"--anchor-overflow-wrap" = "break-word"
"--anchor-overflow-wrap-print" = "break-word"
"--anchor-word-break" = "break-word"
"--anchor-word-break-print" = "break-word"
"--anchor-letter-spacing" = "initial"
"--anchor-line-height" = "var(--body-line-height)"
"--anchor-text-align" = "initial"
Expand Down
1 change: 0 additions & 1 deletion hestiaHUGO/layouts/partials/hestiaGUI/zoralabBUTTON/ToCSS
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ button, .button {
text-decoration: var(--button-text-decoration);
text-transform: var(--button-text-transform);
overflow-wrap: var(--button-overflow-wrap);
word-break: var(--button-word-break);
line-height: var(--button-line-height);

color: var(--button-color);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"--button-text-align" = "center"
"--button-text-decoration" = "none"
"--button-text-transform" = "uppercase"
"--button-word-break" = "normal"
"--button-overflow-wrap" = "normal"
"--button-overflow-wrap" = "break-word"
"--button-line-height" = "var(--body-line-height)"


Expand Down
8 changes: 4 additions & 4 deletions sites/data/Specs/hestiaGUI/zoralabANCHOR/Designs.toml
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ Affects the word breaking behavior of the rendered component.
Code = '''
VARIABLE : --anchor-word-break
CSS PROPERTY : word-break
DEFAULT : break-word (>= v1.2.0)
DEFAULT : REMOVED (>= v1.2.1) break-word (== v1.2.0)
'''

[[EN.List.SubList.URL]]
Expand All @@ -1138,7 +1138,7 @@ Plain = '''
Code = '''
变化值 : --anchor-word-break
CSS属性 : word-break
默认数码 : break-word (>= v1.2.0)
默认数码 : 删除没用了 (>= v1.2.1) break-word (== v1.2.0)
'''

[[ZH-HANS.List.SubList.URL]]
Expand All @@ -1158,7 +1158,7 @@ Affects the word breaking behavior of the rendered component.
Code = '''
VARIABLE : --anchor-word-break
CSS PROPERTY : word-break
DEFAULT : break-word (>= v1.2.0)
DEFAULT : REMOVED (>= v1.2.1) break-word (== v1.2.0)
'''

[[EN.List.SubList.URL]]
Expand All @@ -1177,7 +1177,7 @@ Plain = '''
Code = '''
变化值 : --anchor-word-break
CSS属性 : word-break
默认数码 : break-word (>= v1.2.0)
默认数码 : 删除没用了 (>= v1.2.1) break-word (== v1.2.0)
'''

[[ZH-HANS.List.SubList.URL]]
Expand Down
8 changes: 4 additions & 4 deletions sites/data/Specs/hestiaGUI/zoralabBUTTON/Designs.toml
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ Affects the word breaking behavior of the rendered component.
Code = '''
VARIABLE : --button-word-break
CSS PROPERTY : word-break
DEFAULT : normal (>= v1.2.0)
DEFAULT : REMOVED (>= v1.2.1) normal (== v1.2.0)
'''

[[EN.List.SubList.URL]]
Expand All @@ -717,7 +717,7 @@ Plain = '''
Code = '''
变化值 : --button-word-break
CSS属性 : word-break
默认数码 : normal (>= v1.2.0)
默认数码 : 删除没用了 (>= v1.2.1) normal (== v1.2.0)
'''

[[ZH-HANS.List.SubList.URL]]
Expand All @@ -737,7 +737,7 @@ Affects the overflow wrapping behavior of the rendered component.
Code = '''
VARIABLE : --button-overflow-wrap
CSS PROPERTY : overflow-wrap
DEFAULT : normal (>= v1.2.0)
DEFAULT : break-word (>= v1.2.1) normal (== v1.2.0)
'''

[[EN.List.SubList.URL]]
Expand All @@ -756,7 +756,7 @@ Plain = '''
Code = '''
变化值 : --button-overflow-wrap
CSS属性 : overflow-wrap
默认数码 : normal (>= v1.2.0)
默认数码 : break-word (>= v1.2.1) normal (== v1.2.0)
'''

[[ZH-HANS.List.SubList.URL]]
Expand Down

0 comments on commit 746a8c2

Please sign in to comment.