Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support YOLOv5 and fix bugs #272

Merged
merged 4 commits into from
May 24, 2024
Merged

[feature] support YOLOv5 and fix bugs #272

merged 4 commits into from
May 24, 2024

Conversation

cjliu01
Copy link

@cjliu01 cjliu01 commented May 23, 2024

add some contents about YOLOv5 detector, tracking results showing and modify some errors about kalman_filter.py, detector.YOLOv3.weight.yolo_utils.py(This eliminates the need for compiling NMS operators).

@cjliu01
Copy link
Author

cjliu01 commented May 23, 2024

later modifications to READMD.md will be uploaded, as well as updates to the appearance feature extraction network.

@ZQPei
Copy link
Owner

ZQPei commented May 23, 2024

Thanks a lot for your contribution!
This PR title is a bit confusing. It will be much better to use a more descriptive title instead of ambiguous words like "some".

@cjliu01
Copy link
Author

cjliu01 commented May 23, 2024

tracking

  1. Added resnet network to the appearance feature extraction network in the deep folder
  2. modified the NMS bug in the preprocessing.py and the updated covariance calculation bug in the kalmen_filter.py in the sort folder
    detecting
  3. Added YOLOv5 detector, aligned interface, and added YOLOv5 related yaml configuration files
  4. The training, evaluation and prediction in the original YOLOv5 were deleted
    deepsort
  5. Added tracking target category, which can display both category and tracking ID simultaneously

@ZQPei
Copy link
Owner

ZQPei commented May 23, 2024

tracking

  1. Added resnet network to the appearance feature extraction network in the deep folder
  2. modified the NMS bug in the preprocessing.py and the updated covariance calculation bug in the kalmen_filter.py in the sort folder
    detecting
  3. Added YOLOv5 detector, aligned interface, and added YOLOv5 related yaml configuration files
  4. The training, evaluation and prediction in the original YOLOv5 were deleted
    deepsort
  5. Added tracking target category, which can display both category and tracking ID simultaneously

Great job! Will you update the title as well, please?

@ZQPei
Copy link
Owner

ZQPei commented May 23, 2024

later modifications to READMD.md will be uploaded, as well as updates to the appearance feature extraction network.

I assume these commits will be uploaded soon, correct?
This pull request will be merged once the remaining is ready.

@cjliu01
Copy link
Author

cjliu01 commented May 23, 2024

tracking

  1. Added resnet network to the appearance feature extraction network in the deep folder
  2. modified the NMS bug in the preprocessing.py and the updated covariance calculation bug in the kalmen_filter.py in the sort folder
    detecting
  3. Added YOLOv5 detector, aligned interface, and added YOLOv5 related yaml configuration files
  4. The training, evaluation and prediction in the original YOLOv5 were deleted
    deepsort
  5. Added tracking target category, which can display both category and tracking ID simultaneously

Great job! Will you update the title as well, please?

Is there any standard for naming titles

@cjliu01
Copy link
Author

cjliu01 commented May 23, 2024

later modifications to READMD.md will be uploaded, as well as updates to the appearance feature extraction network.

I assume these commits will be uploaded soon, correct? This pull request will be merged once the remaining is ready.

updated on the appearance feature extraction network and README.md

@cjliu01 cjliu01 changed the title add some contents and modify some errors Add content and modify bug May 23, 2024
@ZQPei ZQPei changed the title Add content and modify bug [feature] support YOLOv5 and fix bugs May 24, 2024
@ZQPei ZQPei merged commit 2e09ffc into ZQPei:master May 24, 2024
@ZQPei
Copy link
Owner

ZQPei commented May 24, 2024

@cjliu01 Hi, it's me again.
I noticed that the previous PR(#262), that trying to add MaskRCNN to detector, now has conflicts with master.
Is it convenient for you to solve these conflicts that introduced by your PR with the previous one (#262)?
It will be really nice of you to help us out.

@cjliu01
Copy link
Author

cjliu01 commented May 24, 2024

I will try to merge MaskRCNN into the main branch, but it will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants