test: prevent infinite loop when zplayer exits before first frame

ZQuestClassic · Nov 29, 2023 · a56646b · a56646b
1 parent d90410d
commit a56646b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tests/run_replay_tests.py b/tests/run_replay_tests.py
@@ -863,6 +863,9 @@ def on_result_updated(w: ReplayResultUpdatedHandler):
             while watcher.observer.is_alive():
                 watcher.update_result()
 
+                if player_interface.poll() != None:
+                    break
+
                 # Don't apply timeout until beyond the first frame, since JIT may take a moment for big scripts.
                 if watcher.result['frame'] == 0:
                     continue
@@ -871,9 +874,6 @@ def on_result_updated(w: ReplayResultUpdatedHandler):
                     last_frame = watcher.result['frame']
                     raise ReplayTimeoutException(f'timed out, replay got stuck around frame {last_frame}')
 
-                if player_interface.poll() != None:
-                    break
-
                 yield (key, 'status', result)
 
             player_interface.wait_for_finish()