Update design docs. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 23
💛 - Coveralls |
guangxuli
reviewed
Apr 8, 2018
docs/design.md
Outdated
|
|
||
| - stability mechanism of Pod IP address | ||
|
|
||
| - in many cases, Pod need to have specified IP address or make sure its IP address not changing after restarting. Knitter introduces a concept of IP group which can support IP address stablity well. |
guangxuli
reviewed
Apr 8, 2018
docs/design.md
Outdated
| ## Features | ||
|
|
||
| - support for multiple networks/interfaces. | ||
| - in telecommunication senarios, service data traffic is generally separated into several network planes, e.g., control plane, data plane and management plane. Those types of traffic have different QoS requirements. Multiple network interfaces are needed to isolate the networks and provide QoS ability. The current Kubernetes network model doesn't support multiple networks while Knitter can meet the multiple networks requirements. |
There was a problem hiding this comment.
senarios -> scenarios will be normally used IMO.
If you agree this, please sweep other words :)
guangxuli
reviewed
Apr 8, 2018
docs/design.md
Outdated
| @@ -0,0 +1,102 @@ | |||
| # Knitter Features and Design | |||
|
|
|||
| [TOC] | |||
There was a problem hiding this comment.
TOC seems doesn't work well in github.
There was a problem hiding this comment.
TOC is not so necessary in this doc, so I remove it.
xiangpengzhao
force-pushed
the
design-docs
branch
from
1f85822
to
13ee790
Compare
xiangpengzhao
commented
Apr 8, 2018
docs/design.md
Outdated
|
|
||
| Take setting up networks for pod for example, the workflow of interaction among the components is shown as the below diagram. | ||
|
|
||
| ```mermaid |
There was a problem hiding this comment.
mermaid is not supported on github. I will replace with image.
xiangpengzhao
force-pushed
the
design-docs
branch
from
13ee790
to
0e49c3d
Compare
|
@guangxuli updated. PTAL. Thanks! |
|
LGTM |
|
THANKS peter !!! |
|
ohh, we should update the image path from ./docs/images/ to ./images/, i will file another PR to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR:
Updated the design doc. There might be further updating needed.
Which issue(s) this PR fixes(we suggest there is at least one issue related to this PR)
Fixes # none
cc @guangxuli