Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systemd conf files. #7

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Add systemd conf files. #7

merged 1 commit into from
Mar 26, 2018

Conversation

xiangpengzhao
Copy link
Collaborator

@guangxuli
Copy link
Contributor

guangxuli commented Mar 23, 2018 •
edited

I saw you use knitter-cni-plugin.service, knitter-cni-plugin is a better name than knitter-plugin which we have defined in our doc\script\bianries.etc. How do you thinks? I will file another PR to fix this.
Any way this LGTM.

@xiangpengzhao
Copy link
Collaborator Author

knitter-cni-plugin is a better name

Agreed. However, knitter-cni-plugin is not a daemon process, so I removed the existing empty placeholder file knitter-cni-plugin.service of it.

@guangxuli
Copy link
Contributor

SGTM

@guangxuli guangxuli merged commit 4543769 into ZTE:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiangpengzhao @guangxuli