Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ABI validator + modernize gradle extension #39

Merged
merged 5 commits into from Jan 9, 2021
Merged

Integrate ABI validator + modernize gradle extension #39

merged 5 commits into from Jan 9, 2021

Conversation

ZacSweers
Copy link
Owner

Resolves #34

@ZacSweers ZacSweers mentioned this pull request Jan 9, 2021
Closed
@ZacSweers
Copy link
Owner Author

Pausing on this due to Kotlin/binary-compatibility-validator#34

@drewhamilton
Copy link
Contributor

Your settings.gradle is not including :sample-android on JDK 9+: https://github.com/ZacSweers/redacted-compiler-plugin/blob/main/settings.gradle#L6-L9

@ZacSweers
Copy link
Owner Author

D'oh 😐😐😐😐

@ZacSweers ZacSweers merged commit 1d16ec2 into main Jan 9, 2021
@ZacSweers ZacSweers deleted the z/moarGradle branch January 9, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate kotlin ABI validator
2 participants
@ZacSweers @drewhamilton