fix nuxt compilation error #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A compiler error is thrown when building a Nuxt app inside of a workspace that also has a Vue app.
The error is thrown because
nuxt>=2.15.0 depends oncss-loaderv4, but when used in a workspace with a Vue appcss-loaderv3 is resolved. The error isn't thrown until v2.15.4 when thecompileTypeoption is set, but it not being set was a bug so that's why I pinned the version at v2.14.12.To reproduce:
yarn create-playgroundcd tmp/nx-playground/projnx g @nx-plus/vue:app my-vue-app --style css --routing false --vueVersion 2 --babel falsenx g @nx-plus/nuxt:app my-nuxt-appnx serve my-nuxt-appExpected Behavior
No compilation error.