Filenames can be unicode.

Fixes PyAV-Org#82.

CHANGELOG.rst

@@ -23,6 +23,7 @@ Fixes:
 - Packets retain their refcount after muxing. (#334.)
 - `Codec` construction is more robust to find more codecs. (#332 by @adavoudi).
 - Refined frame corruption detection. (#291 by @Litterfeldt.)
+- Unicode filenames are okay. (#82.)
 
 
 v0.4.0

av/container/core.pxd

@@ -16,8 +16,9 @@ cdef class ContainerProxy(object):
     cdef seek(self, int stream_index, offset, str whence, bint backward, bint any_frame)
     cdef flush_buffers(self)
 
+
     # Copies from Container.
-    cdef str name
+    cdef object name
     cdef str metadata_encoding
     cdef str metadata_errors
 
@@ -41,7 +42,7 @@ cdef class ContainerProxy(object):
 
 cdef class Container(object):
 
-    cdef readonly str name
+    cdef readonly object name
     cdef readonly object file
 
     cdef readonly bint writeable

av/container/core.pyx

@@ -16,6 +16,11 @@ from av.dictionary import Dictionary # not cimport
 from av.logging import Capture as LogCapture # not cimport
 from av.utils import AVError # not cimport
 
+try:
+    from os import fsencode
+except ImportError:
+    _fsencoding = sys.getfilesystemencoding()
+    fsencode = lambda s: s.encode(_fsencoding)
 
 
 
@@ -75,8 +80,8 @@ cdef class ContainerProxy(object):
         self.name = container.name
         self.writeable = container.writeable
 
-        cdef char *name = self.name
-
+        cdef bytes name_obj = fsencode(self.name) if isinstance(self.name, unicode) else self.name
+        cdef char *name = name_obj
 
         cdef lib.AVOutputFormat *ofmt
         if self.writeable:
@@ -250,7 +255,9 @@ cdef class Container(object):
         if isinstance(file_, basestring):
             self.name = file_
         else:
-            self.name = str(getattr(file_, 'name', None))
+            self.name = getattr(file_, 'name', '<none>')
+            if not isinstance(self.name, basestring):
+                raise TypeError("File's name attribute must be string-like.")
             self.file = file_
 
         if format_name is not None:

av/utils.pxd

@@ -5,7 +5,7 @@ cimport libav as lib
 
 cdef int stash_exception(exc_info=*)
 
-cpdef int err_check(int res=*, str filename=*) except -1
+cpdef int err_check(int res=*, filename=*) except -1
 
 
 

av/utils.pyx

@@ -62,7 +62,7 @@ cdef int stash_exception(exc_info=None):
 
 cdef int _last_log_count = 0
 
-cpdef int err_check(int res=0, str filename=None) except -1:
+cpdef int err_check(int res=0, filename=None) except -1:
 
     global _err_count
     global _last_log_count

tests/test_container.py

@@ -0,0 +1,11 @@
+# coding: utf8
+
+from common import *
+
+
+class TestContainers(TestCase):
+
+    def test_unicode_filename(self):
+
+        container = av.open(self.sandboxed(u'¢∞§¶•ªº.mov'), 'w')
+