Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Depot Downloader not working on Linux #297

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix Depot Downloader not working on Linux #297

merged 2 commits into from
Aug 9, 2023

Conversation

Insprill
Copy link
Contributor

@Insprill Insprill commented Aug 9, 2023

Scope

Fixes the Depot Downloader not functioning on Linux.
This should be double-checked to ensure Windows compatibility is not affected.

Implementation

Instead of directly invoking the exe, it will run the DLL through dotnet when Linux is detected.

How to Test

  • Try downloading a version of Beat Saber on Linux and Windows.

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟒 Nice refactor!

🟑 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

πŸ”΄ This change will break something important

Blocking πŸ”΄ ❌ 🚨 RED
Non-blocking 🟑 πŸ’‘ πŸ€” πŸ’­ Yellow, thinking, etc
Praise 🟒 πŸ’š 😍 πŸ‘ πŸ™Œ Green, hearts, positive emojis, etc

src/main/services/bs-installer.service.ts Outdated Show resolved Hide resolved
src/main/services/bs-installer.service.ts Outdated Show resolved Hide resolved
src/main/services/bs-installer.service.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Insprill
Copy link
Contributor Author

Insprill commented Aug 9, 2023

I don't believe the security hotspot SonarCloud flagged is relevant here, since dotnet may be located differently depending on the user's system, but if there's a different way to do it please let me know.

@Zagrios
Copy link
Owner

Zagrios commented Aug 9, 2023

All good πŸ‘ thanks for that πŸ˜‰

@Zagrios Zagrios merged commit 288c219 into Zagrios:master Aug 9, 2023
6 checks passed
@Insprill Insprill deleted the fix/depot-downloader-linux branch August 9, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants